[Bug 807038] Review Request: aspell-uk - Dictionary and affix files for the aspell programs for Ukrainian language.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=807038

--- Comment #2 from Jon Ciesla <limburgher@xxxxxxxxx> ---
- rpmlint checks return:

spell-uk.spec:15: W: unversioned-explicit-provides spell-%{languagecode}
The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing.  This may cause update
problems and will make versioned dependencies, obsoletions and conflicts on
the provided thing useless -- make the Provides versioned if possible.

Fix.

aspell-uk.src: W: spelling-error %description -l en_US ukrainian -> Ukrainian
The value of this tag appears to be misspelled. Please double-check.

Fix.

aspell-uk.src: W: spelling-error %description -l en_US spellchecking -> spell
checking, spell-checking, spellchecker
The value of this tag appears to be misspelled. Please double-check.

Ignore.

aspell-uk.src: W: file-size-mismatch spell-uk-1.6.5.tgz = 836332,
http://freefr.dl.sourceforge.net/project/ispell-uk/spell-uk/1.6.5/spell-uk-1.6.5.tgz
= 836333
The size of the file in the package does not match the size indicated by
peeking at its URL.  Verify that the file in the package has the intended
contents.

Fix.

aspell-uk.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

Fix.

aspell-uk.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

Fix.

- package meets naming guidelines
- package meets packaging guidelines

See above.
Also, Source0 URL is incorrect: 
https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

- license ( LGPLv3 ) OK, text in %doc, matches source

The Copyright file says GPLv2+ or LGPLv2+.

- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

That should get you started.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]