https://bugzilla.redhat.com/show_bug.cgi?id=809086 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx --- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- OK, I grabbed and built the package. rpmlint has a lot of complaints. I'll go over some of them, but I'm not sure why you didn't see and fix them when you ran rpmlint yourself. Also, it's bit of a stretch to call two months and one day "several months". mp3val.x86_64: E: description-line-too-long C integrity. It can be useful for finding corrupted files (e.g. incompletely downloaded, mp3val.x86_64: E: description-line-too-long C truncated, containing garbage). MP3val is also able to fix most of the problems. Being mp3val.x86_64: E: description-line-too-long C a multiplatform application, MP3val can be runned both under Windows and under Linux mp3val.x86_64: E: description-line-too-long C The most common MPEG audio file type is MPEG 1 Layer III (mp3), but MP3val supports also mp3val.x86_64: E: description-line-too-long C other MPEG versions and layers. The tool is also aware of the most common types of tags Please wrap your description to 72 characters. mp3val.x86_64: W: incoherent-version-in-changelog 0.1.8-1 ['0.1.8-2.fc18', '0.1.8-2'] You should have a changelog entry each time you update the version/release. mp3val.x86_64: W: spurious-executable-perm /usr/share/doc/mp3val-0.1.8/manual.html mp3val.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/mp3val-0.1.8/manual.html Why is the manual executable? DOS-style line endings need to be converted. mp3val.x86_64: W: no-manual-page-for-binary mp3val This is OK; you should ask upstream to provide a manual page, or perhaps see if Debian has written one, but it's not expected that you will provide one yourself. mp3val-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/mp3val-0.1.8-src/main.cpp mp3val-debuginfo.x86_64: E: wrong-script-end-of-line-encoding /usr/src/debug/mp3val-0.1.8-src/main.cpp There are loads of these. The DOS line endings of the source files aren't such a big deal, but why on earth are they all executable. mp3val-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/mp3val-0.1.8-src/main.cpp You should tell your upstream that they need to update the license to reflect the fact that the FSF moved quite some time ago. It does look as if your upstream hasn't done much in three years, though, so this might not be something you can fix but you should still inform them. (trimmed several repeat versions of the above three complaints) As for the spec file, it looks quite clean. However, you should not use %{__install}. Instead just call "install" normally. It's not as if we're ever going to rename the install executable or remove it from the path. See http://fedoraproject.org/wiki/Packaging:Guidelines#Macros -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review