https://bugzilla.redhat.com/show_bug.cgi?id=837726 Bug ID: 837726 QA Contact: extras-qa@xxxxxxxxxxxxxxxxx Severity: medium Version: rawhide Priority: medium CC: notting@xxxxxxxxxx, package-review@xxxxxxxxxxxxxxxxxxxxxxx Assignee: nobody@xxxxxxxxxxxxxxxxx Summary: Review Request: eclipse-jbosstools - A set of Eclipse plugins that supports JBoss and related technology Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: gerard@xxxxxxx Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora Spec URL: http://galileo.fedorapeople.org/eclipse-jbosstools/3.3.0/eclipse-jbosstools.spec SRPM URL: http://galileo.fedorapeople.org/eclipse-jbosstools/3.3.0/eclipse-jbosstools-3.3.0-0.1.Final.fc17.src.rpm Description: A set of Eclipse plugins that supports JBoss and related technology Fedora Account System Username: galileo There are a number of things that I'm not fully sure about, comments/advice welcome: 1. The package name. I'm not sure if the 'eclipse-' prefix is for all eclipse plugin packages (such as this), or just plugin packages from eclipse.org. 2. Packaging with maven. There are so many pom.xml files, what's the procedure for deciding which ones get installed? I've a feeling that I've done it in a haphazard sort of way here. 3. The package layout. I don't know if the layout/structure of the rpms is optimal. The reasoning behind the current structure is that if someone does 'yum install eclipse-jbosstools', then they want all of them. There isn't an eclipse-jbosstools rpm though, it just requires all the other subpackages. I'm not sure if that makes sense. 4. The source archive. I've removed the components that aren't being built from the source .tar.xz file. It's big enough without them, but when they're included it's absolutely huge. It would take a long time to extract each time it's being built (it would also take me quite a while to upload). If this is wrong I'll change it of course. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review