https://bugzilla.redhat.com/show_bug.cgi?id=833562 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #4 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Ah, just seen in the packaging guidelines: MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. Means, your package is OK so far. This is because I use a custom review template, and this doesn't include the "and only if" clause. I've never reviewed a package before, which doesn't ship a COPYING or LICENSE file... However, for better reading you should drop libX11-devel from BR, but this doesn't affect that your package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review