https://bugzilla.redhat.com/show_bug.cgi?id=772766 Jiri Popelka <jpopelka@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |jpopelka@xxxxxxxxxx Flags| |fedora-review? --- Comment #4 from Jiri Popelka <jpopelka@xxxxxxxxxx> --- Package Review ============== Key: - = N/A x = Pass ! = Fail ==== Python ==== [x]: MUST Python eggs must be built from source. [x]: MUST Python eggs must not download any dependencies during the build process. You don't need to define python_sitelib macro, see https://fedoraproject.org/wiki/Packaging:Python#Macros ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 [-]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. MD5SUM this package : cf067e2abc091804385974dd146b2090 MD5SUM upstream package : cf067e2abc091804385974dd146b2090 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD Dist tag is present. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. Issues: [!]: MUST Package must own all directories that it creates. Add %dir %{_datadir}/%{name} to %files [!]: MUST Rpmlint output is silent. stylus-toolbox.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/GladeWindow.py 0644L /usr/bin/env I'd just remove the shebang during install. stylus-toolbox.src: W: spelling-error %description -l en_US reult -> result, re ult, re-ult Fix this typo. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review