https://bugzilla.redhat.com/show_bug.cgi?id=819687 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tibbs@xxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flags| |fedora-review? --- Comment #7 from Jason Tibbitts <tibbs@xxxxxxxxxxx> --- I'll assume that because you don't clean the buildroot in %install that you don't intend to submit this for EL5. Given that, here's a review: The first line of the spec is pointless regardless of what releases you intend to package for. The python_sitelib define at the top is unnecessary; all Fedora and EL6 already have this. BuildRoot: is unnecessary, as is the %clean section. The Summary: and %description are rather deficient; neither really tells me much about the package. Unfortunately these appear to come from upstream. I'll suggest these: Summary: A python interface to the Request Tracker API %description A Python module providing access to the Best Practical Request Tracker (RT) REST interface. Not the best, I guess, but better than what's there. The package is out of date; the current version appears to be 0.2.4. I'll go ahead and take this for review, but you should update to the current version before I get any further into it. Unless, of course, you have a reason for not updating to the current version. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review