[Bug 835089] Review Request: Script-Tools - A script framework based on bash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=835089

Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs@xxxxxxxxxxx

--- Comment #12 from Jason Tibbitts <tibbs@xxxxxxxxxxx> ---
Some notes:

Relocatable packages aren't permitted in Fedora anyway.

The versioning doesn't meet the guidelines; there are only very limited
circumstances where something is permitted after the dist tag.  If your package
is a prerelease of what will eventually be called 0.6.3, it should be
0.6.3-0.4.alpha1%{?dist}.  Note that the release is less than 1 because it's a
prerelease version, and when 0.6.3 is released you can just use
0.6.3-1%{?dist}.
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

You really must untar your source in %prep, not in %install.

If you do not intend to support RHEL5, you do not need BuildRoot, %clean or the
first line of %install.  Nothing needs the %defattr line in %files.

rpmlint gives a really large number of non-executable script warnings, and some
really odd stuff like
  script-tools.noarch: W: dangling-symlink
   /usr/share/script-tools/scripts/simon /home/simon/bin/simon-scripts

You... can't refer to your home directory in an rpm spec file which will be
built and installed on systemd that don't have your home directory.

The last changelog entry doesn't match the package version, and your changelog
entries don't follow one of the formats specified in the packaging guidelines:
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

I can't figure out how users are supposed to run any of these scripts as
nothing gets installed anywhere in the path.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]