https://bugzilla.redhat.com/show_bug.cgi?id=819670 Michael Cronenworth <mike@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from Michael Cronenworth <mike@xxxxxxxxxx> --- $ md5sum Downloads/llvm-3.0.tar.gz a8e5f5f1c1adebae7b4a654c376a6005 Downloads/llvm-3.0.tar.gz $ md5sum rpmbuild/SOURCES/llvm-3.0.tar.gz a8e5f5f1c1adebae7b4a654c376a6005 rpmbuild/SOURCES/llvm-3.0.tar.gz $ rpmlint rpmbuild/SPECS/mingw-llvm.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint Downloads/mingw-llvm-3.0-3.fc17.src.rpm mingw-llvm.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint /home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-3.0-3.fc17.noarch.rpm mingw32-llvm.noarch: W: no-manual-page-for-binary i686-w64-mingw32-llvm-config 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint /home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-static-3.0-3.fc17.noarch.rpm mingw32-llvm-static.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpm -qp --requires /home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-3.0-3.fc17.noarch.rpm /usr/bin/perl mingw32(advapi32.dll) mingw32(imagehlp.dll) mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libstdc++-6.dll) mingw32(llvm-3.0.dll) mingw32(msvcrt.dll) mingw32(psapi.dll) mingw32(shell32.dll) mingw32-crt mingw32-filesystem >= 83 perl >= 0:5.006 perl(Cwd) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -qp --provides /home/michael/rpmbuild/RPMS/noarch/mingw32-llvm-3.0-3.fc17.noarch.rpm mingw32(bugpointpasses.dll) mingw32(llvm-3.0.dll) mingw32(lto.dll) mingw32-llvm = 3.0-3.fc17 + OK ! Needs to be looked into / Not applicable [+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [/] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [/] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [/] Libtool .la files are not bundled [/] .def files are not bundled [+] Man pages which duplicate native package are not bundled [/] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal The description and man page rpmlint warnings can be ignored. The no-documentation rpmlint warnings in the -static subpackage can be ignored as the documentation is already part of the regular mingw32 package. However, I could not build your package on my x86_64 F17 system at first. The configure steps succeed but building fails during the make step: checking tool compatibility... configure: error: g++|clang++|icc required but not found make[1]: Entering directory `/home/michael/rpmbuild/BUILD/llvm-3.0.src/build_win32/BuildTools' make[1]: *** No targets specified and no makefile found. Stop. make[1]: Leaving directory `/home/michael/rpmbuild/BUILD/llvm-3.0.src/build_win32/BuildTools' make: *** [cross-compile-build-tools] Error 1 It seems when it runs make it is throwing out all of the MinGW environment variables and running configure again. I do not have g++ installed on the system I am reviewing on. After installing it (as a koji buildroot would have it) building succeeded. You might ask upstream why the "make" process wants native compilers when we specified a cross-compiler (MinGW) during configure. In any case it seems to build Windows binaries. ================================================ The package mingw-llvm is APPROVED by mooninite ================================================ -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review