https://bugzilla.redhat.com/show_bug.cgi?id=831705 --- Comment #4 from Petr Šabata <psabata@xxxxxxxxxx> --- (In reply to comment #2) > Issues: > [!]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise > justified. > > The jj-1-optflags.patch references $RPM_OPT_FLAGS so it is not upstreamable. > Please change the patch to use the standard $CFLAGS environment variable, and > then submit this upstream and add a link in the spec to where you have > submitted it. (You will of course have to adjust the spec to pass make > CFLAGS="$RPM_OPT_FLAGS" as well.) Thanks for the comments. The updated package is here: http://psabata.fedorapeople.org/pkgs/jj/jj.spec http://psabata.fedorapeople.org/pkgs/jj/jj-1-2.fc16.src.rpm And here's the upstream Github pull request: https://github.com/Petteri/jj/pull/2 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review