[Bug 837004] Review Request: libpari23 - Number Theory-oriented Computer Algebra Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=837004

pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paulo.cesar.pereira.de.andr
                   |                            |ade@xxxxxxxxx

--- Comment #1 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> ---
Building on an installed system (to check for possible conflicts), not a
buildroot I got this:

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/emacs/site-lisp/pari/pari-completion.el
   /usr/share/emacs/site-lisp/pari/pari-completion.elc
   /usr/share/emacs/site-lisp/pari/pari-conf.el
   /usr/share/emacs/site-lisp/pari/pari-conf.elc
   /usr/share/emacs/site-lisp/pari/pari-fontification.el
   /usr/share/emacs/site-lisp/pari/pari-fontification.elc
   /usr/share/emacs/site-lisp/pari/pari-help.el
   /usr/share/emacs/site-lisp/pari/pari-messages.el
   /usr/share/emacs/site-lisp/pari/pari-messages.elc
   /usr/share/emacs/site-lisp/pari/pari.el
   /usr/share/emacs/site-lisp/pari/pari.elc
   /usr/share/emacs/site-lisp/pari/pariemacs.txt
   /usr/share/emacs/site-lisp/pari/sli-tools.el
   /usr/share/emacs/site-lisp/pari/sli-tools.elc

I suggest something like:
$ diff -u SPECS/libpari23.spec 837004/libpari23.spec
--- SPECS/libpari23.spec        2012-07-02 09:09:50.000000000 -0400
+++ 837004/libpari23.spec       2012-07-02 11:31:53.768642232 -0400
@@ -118,6 +118,9 @@
 # Placate rpmlint regarding binary and library permissions
 %{_fixperms} %{buildroot}{%{_bindir},%{_libdir}}

+# Cleanup emacs in alternate package
rm -fr %{buildroot}%{_datadir}/emacs
+
 %check
 make dobench
 make dotest-compat

After the above, you will need to update perl-Math-Pari.spec, to avoid
$ rpmbuild -ba SPECS/perl-Math-Pari.spec 
error: Failed build dependencies:
        pari-devel = 2.3.5 is needed by perl-Math-Pari-2.010806-13.fc18.x86_64

somewhat like:
$ diff -u SPECS/perl-Math-Pari.spec{~,}
--- SPECS/perl-Math-Pari.spec~  2012-07-02 11:35:37.129650783 -0400
+++ SPECS/perl-Math-Pari.spec   2012-07-02 11:36:57.368653861 -0400
@@ -30,7 +30,7 @@
 Requires:      perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))

 # Enforce dependency against same version of pari that we're built for
-BuildRequires: pari-devel = %{pari_version}
+BuildRequires: libpari23-devel
 Requires:      pari%{?_isa} = %{pari_version}

 # Don't "provide" private Perl libs or the redundant unversioned
perl(Math::Pari)

after the above, I only did need:
$ diff -u SPECS/perl-Math-Pari.spec{.orig,}
--- SPECS/perl-Math-Pari.spec.orig      2012-07-02 11:36:57.368653861 -0400
+++ SPECS/perl-Math-Pari.spec   2012-07-02 11:40:12.704661293 -0400
@@ -62,8 +62,8 @@
 %build
 perl Makefile.PL \
        INSTALLDIRS=vendor \
-       OPTIMIZE="-I%{_includedir}/pari %{optflags}" \
-       parilib="-lpari"
+       OPTIMIZE="-I%{_includedir}/libpari23/pari %{optflags}" \
+       parilib="-lpari23"
 make %{?_smp_mflags}

 %install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]