[Bug 825414] Review Request: flexiport - Flexible communications library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825414

Dan Callaghan <dcallagh@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |BuildFails

--- Comment #3 from Dan Callaghan <dcallagh@xxxxxxxxxx> ---
This SRPM fails to build. Looks like it needs

BuildRequires: cmake
BuildRequires: doxygen
BuildRequires: graphviz

You can try building your SRPM with mock (or a scratch build in Koji) to catch
these problems.

A couple of other issues which also need fixing...

Your instructions for building the source tarball aren't quite right.
Presumably you meant something like this:

# git clone git://github.com/gbiggs/flexiport.git ; cd flexiport
# git archive 1b6103daa | bzip2 >flexiport-2.0.0.tar.bz2

which worked for me and produced a tarball matching the one you have.

I'd strongly recommend you use GitHub's tarball generation feature instead,
since it gives a usable source URL. See here:

http://lists.fedoraproject.org/pipermail/devel/2012-April/166267.html

You should also add %{?_isa} to the Requires for the -devel subpackage to make
it arch-specific:

https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package

Please send your gcc47.patch upstream and add a link to the upstream report in
the .spec.

I would also suggest adding a comment above this line explaining its reason:

sed -i 's/extensions/#extensions/' doc/conf.py.in

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]