[Bug 812758] Review Request: trader - Star Traders, a simple game of interstellar trading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=812758

--- Comment #6 from John Zaitseff <J.Zaitseff@xxxxxxxxxx> ---
Thank you, Jason, for your detailed comments: I do appreciate them! 
Unfortunately, you've caught me at a bad time: I will be overseas and out of
e-mail/web contact for almost seven weeks, starting from a few hours' time (I'm
about to fly out and, yes, there are still places in the world like that).  I
will be responding to your comments in detail once I return.

In the meantime, just a few comments:

* I like the simplified RPM spec file, and given that I already have split off
OpenSUSE specifics into another file, it will be easy to do, too.

* I did not realise that bundling gnulib had to be declared.  I'm also happy to
work out a way NOT to bundle (or, rather, to use the Fedora gnulib instead of
the bundled one)---once I return from overseas.

* gperf is used (or, at least, was used) by gnulib to create iconv_open header
files.  The current lib/Makefile.am lists the files
iconv_open-aix.h,iconv_open-hpux.h, iconv_open-irix.h, iconv_open-osf.h and
iconv_open-solaris.h as requiring gperf; I think this list was larger in older
versions of gnulib.

I'd like to work on this now, but I have a flight to catch...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]