[Bug 823075] Review Request: php-symfony2-Security - Symfony2 Security Component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=823075

--- Comment #6 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
(In reply to comment #4)
> Please check file placement of *sql (mark as doc).
> This files seems not used.

I will update the spec to modify package.xml and make these files role="php". 
Upstream v2.1.0-BETA1 has several packaging fixes in it and these files are
role="php" there.


> You probably need php-doctrine-DoctrineCommon and php-doctrine-DoctrineDBAL
> (not yet packaged).
> 
> So please
> 1/ assure this is an optionnal dep
> 2/ consider submitting a review for this 2packages.

It appears that these are optional.  Looking through the dependency updates for
upstream version 2.1.0 BETA1 (which has several packaging fixes in it), the
PEAR dependencies are the same, but the composer dependencies for those
packages are "require-dev" which means "packages required for developing this
package, or running tests, etc." but not installed as normal required packages.

v2.0.15: https://github.com/symfony/Security/blob/v2.0.15/composer.json
v2.1.0-BETA1:
https://github.com/symfony/Security/blob/v2.1.0-BETA1/composer.json

I am working on the packaging of DoctrineCommon and DoctrineDBAL and will add
them as requires to this package when they are available.


> In Security-2.0.15/Symfony/Component/Security/Acl/Dbal/AclProvider.php
>         foreach ($stmt->fetchAll(\PDO::FETCH_NUM) as $data) {
> 
> So also need php-pdo

I will update the spec with this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]