Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: xterm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226660 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|kevin@xxxxxxxxx |mlichvar@xxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From kevin@xxxxxxxxx 2007-02-06 23:42 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: bf5bb77496ddf95df32b8e752a6cabb0 xterm-223.tgz bf5bb77496ddf95df32b8e752a6cabb0 xterm-223.tgz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. See below - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version 2 outstanding bugs, not package related - check for outstanding bugs on package. Issues: 1. Would it make sense to make a .desktop file for xterm? It is a GUI app... 2. rpmlint sez: rpmlint on ./xterm-debuginfo-223-2.fc7.x86_64.rpm rpmlint on ./xterm-223-2.fc7.src.rpm W: xterm summary-not-capitalized xterm terminal emulator for the X Window System Might make that a cap X (minor, non blocker) W: xterm mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 41) Might pick tabs or spaces and use only one or the other. rpmlint on ./xterm-223-2.fc7.x86_64.rpm W: xterm summary-not-capitalized xterm terminal emulator for the X Window System E: xterm non-standard-gid /usr/bin/xterm utempter E: xterm setgid-binary /usr/bin/xterm utempter 02755 E: xterm non-standard-executable-perm /usr/bin/xterm 02755 Ignoreable. This package has to have a sgid utempter binary to allow it to show login sessions. Once you have addressed these items (either by making the suggested changes, or by explaining why they don't make sense), please reassign this review back to me, and change the 'fedora-review' flag back to ? for me to take action. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review