https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #1 from Jose Pedro Oliveira <jpo@xxxxxxxxxxxx> --- Daryl, This is quick first review: Blocker: * The tarball isn't published by the upstream project [1]. A note in the specfile explaining how it is generated should be imperative so that the source files can be verified. (although I believe it's a subset of the main qpid-0.16 tarball). Minor: * Remove the comments in the %build and %install sections: this a binary RPM and not a noarch one (and perl packagers should be able to review either type). * There is a empty %doc line in the %files section Wishlist: * ship the examples as documentation files (%doc examples/) * contact the perl bindings author so that the patch in the upstream ticket QPID-3313 [2] can be applied (see comments in the upstream ticket) Regards, jpo [1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/ [2] - Update example scripts for perl binding. https://issues.apache.org/jira/browse/QPID-3313 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review