[Bug 827809] Review Request: genbackupdata - A program to generate test data for testing backup software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=827809

--- Comment #7 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is silent (except false positives about spelling):

work ~/Desktop: rpmlint genbackupdata-1.6-2.fc17.*
genbackupdata.noarch: W: spelling-error %description -l en_US filesystems ->
file systems, file-systems, ecosystems
genbackupdata.src: W: spelling-error %description -l en_US filesystems -> file
systems, file-systems, ecosystems
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
work ~/Desktop: 

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv3
or later).
0 No file with the licensing info provided in tarball.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum genbackupdata_1.6.orig.tar.gz*
e8951dda46c51abd9371b7f486417555a3b8fc48d3c84a0302f8987a9bc2ec42 
genbackupdata_1.6.orig.tar.gz
e8951dda46c51abd9371b7f486417555a3b8fc48d3c84a0302f8987a9bc2ec42 
genbackupdata_1.6.orig.tar.gz.1
sulaco ~/rpmbuild/SOURCES: 


+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ All filenames in rpm packages are valid UTF-8.

I didn't find any other issues so this package is

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]