https://bugzilla.redhat.com/show_bug.cgi?id=833462 --- Comment #12 from Scott Tsai <scottt.tw@xxxxxxxxx> --- This review is against the latest .spec file in hawkey git: 1. Remove python2 from BuildRequires python2-devel pulls it in anyway. -BuildRequires: python2 python2-devel +BuildRequires: python2-devel 2. Remove "rm -rf $RPM_BUILD_ROOT" from %install section %install -rm -rf $RPM_BUILD_ROOT Only needed if you're targetting EPEL5. 3. Quote _includedir like other RPM directory name macros -%_includedir/hawkey/ +%{_includedir}/hawkey/ I've uploaded a copy of hawkey.spec with my recommended changes above here: http://scottt.tw/fedora/hawkey.spec I'll approve this package once the points raised above are addressed. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review