https://bugzilla.redhat.com/show_bug.cgi?id=835432 --- Comment #20 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to comment #19) > Hi fellas, > > New package: > http://www.zultron.com/static/2012/06/freecad/python-pycxx.spec > http://www.zultron.com/static/2012/06/freecad/python-pycxx-6.2.4-1.fc16.src. > rpm Ok, I plan to find some time tomorrow to work on the review! > - Source files installed into /usr/src/CXX > - Complies with FHS, though not much written about it > - A precedent is dwm-user, which does very nearly the same thing > - If this is unacceptable, they can be moved into the headers directory Sounds OK to me. > (In reply to comment #17) > > [...] > > (In reply to comment #15) > > > - Own /usr/share/python2.7/ > > > > I'm concerned about this one. I'm not sure anything but python should own a > > directly like that. Perhaps /usr/src was a good idea? > > Fixed, see above. Agreed, /usr/src seems best, and /usr/share/python2.7 is > abominal. > > Whew! Y'all are tough! :) Tough? This is just the informal review. Wait until I start the formal review :) Mostly kidding there, the formal review is largely one giant checklist but I do occasionally find things I don't catch in a quick review. Or course one of the big differences with packaging for a distro vs. packaging for yourself is you have to be more rigorous and unambiguous because someone else might need to update your package and they may not have the intimate knowledge of the package and rely on a nice clean spec with good comments to minimize mistakes. This is especially important in packages like this which are unusual. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review