https://bugzilla.redhat.com/show_bug.cgi?id=824083 --- Comment #5 from Ricky Elrod <codeblock@xxxxxxxx> --- [ok] - Package meets naming and packaging guidelines [ok] - Spec file matches base package name. [ok] - Spec has consistant macro usage. [ok] - Meets Packaging Guidelines. [ok - NCSA] - License [ok] - License field in spec matches [ok - see below] - License file included in package [ok] - Spec in American English [ok] - Spec is legible. [ok] - Sources match upstream md5sum: [ricky@t520 SPECS]$ md5sum ~/Downloads/klange-nyancat-5fe3de9.tar.gz ../SOURCES/klange-nyancat-5fe3de9.tar.gz fef3b947260dcb191e2eed4bcc58b42c /home/ricky/Downloads/klange-nyancat-5fe3de9.tar.gz fef3b947260dcb191e2eed4bcc58b42c ../SOURCES/klange-nyancat-5fe3de9.tar.gz [ok] - BuildRequires correct [ok] - Package has %defattr and permissions on files is good. [ok] - Package has a correct %clean section. [ok] - Package has correct buildroot [ok] - Package is code or permissible content. [ok] - Packages %doc files don't affect runtime. [ok] - Package compiles and builds on at least one arch. [ok] - Package has no duplicate files in %files. [ok] - Package doesn't own any directories other packages own. [ok - see below] - No rpmlint output. SHOULD Items: [ok] - Should build in mock. [ok] - Should build on all supported archs [ok] - Should function as described. [ok] - Should have dist tag [ok] - Should package latest version Issues: 1. Consider asking upstream to include a copy of the license in the repository. (non-blocker) 2. I think the versioning is a bit off, consider: Version: 1 Release: 0.1.%{checkout}%{?dist} 3. There's a manpage now (upstream repo), you probably should include this. rpmlint output: [ricky@t520 SPECS]$ rpmlint ../SRPMS/nyancat-1.0-1.20120522git5fe3de9.fc18.src.rpm nyancat.src: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er nyancat.src: W: spelling-error %description -l en_US poptart -> pop tart, pop-tart, polestar nyancat.src: W: invalid-url Source0: klange-nyancat-5fe3de9.tar.gz 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [ricky@t520 SPECS]$ rpmlint ../RPMS/x86_64/nyancat-1.0-1.20120522git5fe3de9.fc18.x86_64.rpm nyancat.x86_64: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er nyancat.x86_64: W: spelling-error %description -l en_US poptart -> pop tart, pop-tart, polestar nyancat.x86_64: W: no-manual-page-for-binary nyancat 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review