https://bugzilla.redhat.com/show_bug.cgi?id=824976 --- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> --- === Issues === 1. You're placing jars in glassfish directory, but this dir is not owned by any package. There are only 2 jar files, so you don't need to put them into subdir; simply put both files in %{_javadir}. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership corrected 2. I am not sure where does version come from; do you really need to download part from 2.0 and part from 2.1 branches? yes is only required for build and i take a suggestion from here https://build.opensuse.org/package/view_file?file=glassfish-persistence.spec&package=glassfish-persistence&project=Java%3Ajpackage-5.0&rev=e2131cccbf1f703e9677245b44be5d38 How about pulling only http://dlc.sun.com.edgesuite.net/javaee5/v2.1.2_branch/promoted/source/glassfish-v2.1.2-b05g-src.zip looks like it contains all the code you need. i dont want import glassfish 2.x and the source package is very big for 1 library (37MB) Does it need to be 2.x branch at all? yes Maybe it would be better to build 3.1 from svn? non available in 3.x and glassfish 3 require hk2 http://hk2.java.net/ for build 3. Is http://www.oracle.com/technology/products/ias/toplink/jpa/index.html really proper url for this project? Software from that link is licensed differently... maybe you should replace it with http://glassfish.java.net/? corrected === Final Notes === 1. http://download.java.net/ redirects to http://dlc.sun.com.edgesuite.net/ so use newer url, please. corrected Spec URL: http://gil.fedorapeople.org/glassfish-toplink-essentials/3/glassfish-toplink-essentials.spec SRPM URL: http://gil.fedorapeople.org/glassfish-toplink-essentials/3/glassfish-toplink-essentials-2.0.46-3.fc16.src.rpm - moved in files in %%{_javadir} - fixed Url and source0 url -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review