https://bugzilla.redhat.com/show_bug.cgi?id=835617 --- Comment #2 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> --- (In reply to comment #1) > Initial notes: > > > See the following for proper git snapshot versioning. > > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages > Corrected to include the date the snapshot is taken, and the short rev used. I'm going to have to keep the 0.12 prefix and can't go with simply 0.git$date.$rev yet, as 0.11 is already out there. For snapshots, I target to use 0.$x.git<rev> if that's OK with you. > roundcubemail-plugins-kolab.spec:22: W: unversioned-explicit-obsoletes > roundcubemail-kolab > The specfile contains an unversioned Obsoletes: token, which will match all > older, equal and newer versions of the obsoleted thing. This may cause > update > problems, restrict future package/provides naming, and may match something it > was originally not inteded to match -- make the Obsoletes versioned if > possible. > Updated to obsolete only roundcubemail-kolab < %{version}-%{release} > roundcubemail-plugins-kolab.noarch: W: self-obsoletion roundcubemail-kolab > obsoletes roundcubemail-kolab = 3.0-0.11.fc17 > Corrected by versioning the obsoletes. > Several files in /etc/roundcubemail/ that are 640, should be 644. > This is deliberate - only the apache user/group and superusers should be able to read these files (they likely contain passwords to access databases, LDAP and IMAP with privileged accounts). Other POSIX users should not have read access to these files. > roundcubemail-plugins-kolab.src: W: invalid-license GPL > > Should be GPLv3+ Corrected. Spec URL: http://git.kolabsys.com/rpm/roundcubemail-plugins-kolab/plain/roundcubemail-plugins-kolab.spec SRPM URL: http://mirror.kolabsys.com/pub/fedora/kolab-3.0/f17/development/SRPMS/roundcubemail-plugins-kolab-3.0-0.13.git20120628.c5c41f7f.fc17.kolab_3.0.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review