[Bug 834069] Review Request: Clean - The Clean language compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=834069

--- Comment #6 from Paul Wouters <pwouters@xxxxxxxxxx> ---
Note that when writing about software people often capitalize it. I do the same
for Openswan for example. But when people install packages, they most often
assume or look for lovercased package names, and using a capital is just making
it harder for people to find the package.

Some minor things:

warning: File listed twice: /usr/lib64/Clean

warning: File listed twice: /usr/share/doc/Clean

Related: You should not need to use the %{_defaultdocdir}. By adding things
using %doc it should appear at the proper place. It will then also properly
version the doc dir as /usr/share/doc/Clean-2.4-2/ So just do:

%doc doc/*


Clean.x86_64: W: unstripped-binary-or-object /usr/bin/clm

Guess that's unavoidable now with the debuginfo not really working for clean
package. So, OK.

Clean.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/Clean/CleanLangRep/CleanRep.2.2.css

Can you convert that using tr or dos2unix?

# Patch clm to use the /bin directory

Can you patch it for /usr/bin since /bin is a symlink to /usr/bin/

With these, I'll approve the package, though I still have a strong preference
for a package name without a capital C.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]