https://bugzilla.redhat.com/show_bug.cgi?id=833853 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Naming: ok 1. MUST sources: Not ok, not verifiable. no upstream 0.3 tarball (yet?) 6d9a81c318193c2d3ec580b73ffa8886 libkolab-0.3.tar.gz looks like this may be a snapshot, so providing a recipe to create the tarball would be enough. SHOULD: I'd suggest using URL: http://git.kolab.org/libkolab instead of http://kolab.org/ SHOULD: remove rpm cruft like Group:, BuildRoot, %defattr SHOULD: remove extraneous cmake qt-devel deps, like BuildRequires: cmake >= 2.6 BuildRequires: qt-devel >= 4.7 (and similar install-time deps in the -devel subpkg), these are pulled in implicitly via kdepimlibs-devel already SHOULD: track lib soname's explicitly, use %{_libdir}/libkolab.so.0 instead of overly broad %{_libdir}/libkolab.so.* SHOULD: these cmake directives are extraneous and already included in fedora's default %{cmake} macro, so can be removed: -DCMAKE_SKIP_RPATH=ON \ -DCMAKE_INSTALL_PREFIX=%{_prefix} \ -DLIB_INSTALL_DIR=%{_libdir} \ 2. MUST: scriptlets NOT ok, missing: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig Licensing: OK confirmed a mixture of LGPLv2+ and LGPLv3+, though no LICENSE or COPYING file is provided (another SHOULD nice-to-have fix) 3. -devel pkg MUST have and arch'd dep on the main pkg, using Requires: %{name}%{?_isa} = %{version}-%{release} Address at least MUST items 1-3, and looks like we have a winner. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review