https://bugzilla.redhat.com/show_bug.cgi?id=832999 --- Comment #3 from Debarshi Ray <debarshi.ray@xxxxxxxxx> --- * libcolord-gtk/cd-sample-window.[ch] & client/cd-convert.c are under GPLv2+ according to their respective license notices. Also COPYING has the text of the GPLv2 instead of LGPLv2. * You don't really need to specify glib2-devel as a BuildRequires because it is going to be pulled in by gtk3-devel, gobject-introspection-devel, colord-devel, etc.. But it is up to you. * ColordGtk-1.0.gir should be part of the devel package and %{_libdir}/girepository-1.0/ColordGtk-1.0.typelib should be part of the base package. * The devel package should own %{_datadir}/gir-1.0. * The devel package should own %{_datadir}/gtk-doc and %{_datadir}/gtk-doc/html, but not %{_datadir}/gtk-doc/data. The other alternative is to Require: gtk-doc, but it is better to avoid it. * You could mark %{_datadir}/gtk-doc/html/colord-gtk as %doc * %defattr(-,root,root,-) is not needed these days. (http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions) * It is better to require the base package from the devel package as: Requires: %{name}%{?_isa} = %{version}-%{release} (http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review