[Bug 834991] Review Request: perl-Paper-Specs - Size and layout information for paper stock, forms, and labels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=834991

Jørn Lomax <northlomax@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |northlomax@xxxxxxxxx

--- Comment #2 from Jørn Lomax <northlomax@xxxxxxxxx> ---
Again, only informal review:

Rpmlint comes out clean:
>rpmlint perl-Paper-Specs.spec
>rpmlint perl-Paper-Specs-0.10-1.fc18.src.rpm 
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.

One issue was found when running the review:
>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
>     Note: Source0: http://www.cpan.org/authors/id/J/JO/JONALLEN/Paper-
>     Specs-%{version}.tar.gz (Paper-Specs-%{version}.tar.gz) Patch0:
>     fix_Avery_5393.patch (fix_Avery_5393.patch)

while you can't use %{name} for the source, you might want to consider using
%{name} for the patch. 

Have you submitted the patch upstream? If you have, please mention the status
of the patch as a comment in the specfile. You can also give a link to a
upstream bugtracker or mailing list archive if there is one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]