https://bugzilla.redhat.com/show_bug.cgi?id=830992 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #19 from Cole Robinson <crobinso@xxxxxxxxxx> --- Firstly, I agree with recommendations up thread to convert to autotools, the 'known quantity' aspect is hugely beneficial if other packagers ever need to step in a make build or specfile tweaks. But not a blocker here. fedora-review reported issues: Issues: [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 Not relevant since this requires a sufficiently new kernel that RHEL5 will never have. See: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5 [!]: MUST Rpmlint output is silent. rpmlint libseccomp-0.1.0-0.fc18.src.rpm libseccomp.src: W: spelling-error Summary(en_US) seccomp -> sec comp, sec-comp, compose libseccomp.src: W: spelling-error %description -l en_US syscall -> scallop libseccomp.src: W: spelling-error %description -l en_US seccomp -> sec comp, sec-comp, compose libseccomp.src: W: spelling-error %description -l en_US syscalls -> miscalls Not relevant (these errors were also repeated for each sub package, output snipped). libseccomp.src: W: invalid-url URL: http://libseccomp.sourceforge.net HTTP Error 403: Forbidden 1 packages and 0 specfiles checked; 0 errors, 5 warnings. Certainly works for me, so not sure what rpmlint is hitting here. Manual inspection of the spec and upstream sources didn't spot any other problems. Looks good to me! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review