[Bug 833462] Review Request: hawkey - A Library providing simplified C and Python API to libsolv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=833462

--- Comment #9 from Ales Kozumplik <akozumpl@xxxxxxxxxx> ---
(In reply to comment #8)
> Although the section at
> https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
> focuses on explicit library package deps, its bottom is meant to be
> understood
> like
> 
> "In the spec file, you should add comments to all explicit dependencies and
> explain why there is a manually added dependency on something."
> 
> For the python-hawkey package, there is an automatic dependency on
> 
>   python(abi) = 2.7
> 
> already, so your spec file comment should explain why a manually added
> dependency on "python" or "python2" would be needed.

I just removed the dependnecy as there was not a good reason I can remember why
I put it in there. See the latest spec here:
http://akozumpl.fedorapeople.org/review/hawkey_4/hawkey.spec

Scott, will you be able to approve this review now? Thanks, Ales

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]