https://bugzilla.redhat.com/show_bug.cgi?id=834981 Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- - The package should have Provides: bundled(okjson), see the lib/heroku/api/vendor dir. AFAIK okjson has already been approved by FPC to be a copylib, so adding the provide should be fine. - %{gem_instdir}/README.md and %{gem_instdir}/changelog.txt should be marked as %doc. Otherwise the package looks good. Since the mentioned issues are not a blocker, this package is APPROVED (but please fix them before commiting). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review