https://bugzilla.redhat.com/show_bug.cgi?id=834747 --- Comment #8 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> --- (In reply to comment #4) > First of all I really don't like the package's name. Initially I thought > it's about Global Positioning Systems and probably others could be mistaken > as well. > > Could you please rename it? For example into gnat-programming-studio (to be > honest, I really don't know much about a typical Ada workflow and how you > are (Ada developers) usually refer to the tools you're using so keep in mind > this while taking my advices). I believe users typically call it GPS. I see the potential for confusion, but I would like "yum install gps" to install this package. (Could that be achieved with "Provides: gps"?) At the very least it should turn up when someone does "yum search gps". > - rpmlint is NOT silent. Except bogus messages aout spelling mistakes, could > you please explain the rest? I'm especially concerned about rpath,, > executable-stack and zero-length files. Let's get the parameters right first and then see if there are any runpaths left. As noted on https://fedoraproject.org/wiki/Packaging:Ada executable stack is expected because GNAT uses trampolines for pointers to nested functions. > + The package does NOT bundle copies of system libraries. There's something that looks like a copy of Gnatcoll in there. Gnatcoll is already packaged. Is it possible to get GPS to use that? I also found a copy of Templates Parser. Templates Parser is also included in AWS, which is under review in bug 810676. Templates Parser was once distributed as a standalone library, but since it was taken over by Adacore it has only been distributed inside other projects as far as I can find out. None the less it still has its own build system and its own manual. I think Templates Parser needs to be broken out into a subpackage built from either the AWS or the GPS source package (but named templates-parser, not gps-templates-parser). I'm not sure which is best, but I think the risk of circular dependencies may be smaller if it's built from the GPS source. Adacore bundle libraries a lot. There could be more that I haven't found. > 0 The package DOESN'T have a %clean section, so it won't build cleanly on > systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware. > 0 At the beginning of %install, the package does not run rm -rf > %{buildroot} (or $RPM_BUILD_ROOT) so it won't build cleanly on systems with > old rpm (EL-4 and EL-5, not sure about EL-6). Beware. EL-6 doesn't need those. We don't have any other Ada packages in EL-4 or EL-5. > Are these gcc arguments are valid Fedora gcc arguments for Ada or not? In > case we do have them. No, all the standard compiler and linker flags are missing. The spec file does define GNAT_OPTFLAGS but this doesn't seem to have the intended effect. Maybe try overriding the Make variable on the command line instead? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review