[Bug 819480] Review Request: limesurvey - a web-based survey application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=819480

--- Comment #20 from Dan Mashal <dan.mashal@xxxxxxxxx> ---
After further investigation RC4 has been released.

This brings me to my first point:

1) If you are going to become the package maintainer for something you MUST
KEEP UP WITH UPSTREAM! If you can't then don't package a release candidate or
package the latest stable version!
2) Your spec file was a complete mess. I had to clean it up and redo it by
hand. Please review the spec file that I have done and try to install the rpm I
have built by hand.
3) Again, I do not like the idea of making this an apache specific package.
While I understand apache is the official/default webserver of Fedora not
everyone runs "httpd". Please keep this in mind and plan for it in your
package.
4) I would even go so far as to remove the httpd in the requires field or
create a seperate package for nginx and/or lighthttpd or script it in a way so
that the configure script checks for the webserver that is installed on the end
user's machine.


I have built RC4 successfully after revising the spec file and using the latest
source, and changing the URL to my fedorapeople URL.

links:

http://vicodan.fedorapeople.org/limesurvey.spec
http://vicodan.fedorapeople.org/limesurvey200RC4-build120622.tar.gz
http://vicodan.fedorapeople.org/limesurvey-2.0-1.fc17.src.rpm
http://vicodan.fedorapeople.org/limesurvey-2.0-1.fc17.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]