https://bugzilla.redhat.com/show_bug.cgi?id=785492 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx, | |shawn.iwinski@xxxxxxxxx Whiteboard| |NotReady --- Comment #2 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- I am not an official package reviewer, but here are some comments I have for this package: *** Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** Per package.xml requirements, please add: Requires: php-common >= 5.2.0 *** phpci results: For completeness, you may wish to require the package "php-mbstring" and the virtual package (to prevent any future packaging issues due to PHP package changes) "php-zlib". While package.xml lists these as optional, I believe this package would provide a better end-user experience if you added the two requires. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review