Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: symlinks https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226445 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-02-06 11:57 EST ------- A very interesting case ;) 1. rpmlint: W: symlinks summary-ended-with-dot A utility which maintains a system's symbolic links. Stylishness - Should be fixed. W: symlinks invalid-license distributable More on this below. W: symlinks no-url-tag Doesn't make much sense, but to satisfy the burecrats, I'd propose to use URL: ftp://metalab.unc.edu/pub/Linux/utils/file/ 2. License Could not find an explict license, but a terse "freely distributably" inside of the *.lsm. tsx-11 origin => Very old, widely used and known to be distributable package - IMO "distributable" is the correct term for this. 3. *.spec: Would you explain the getconf-call in: make CFLAGS="$RPM_OPT_FLAGS $(getconf LFS_CFLAGS)" getconf causes the package to use the flags it receives from system the package is being built on => - Potential (I am inclined to think almost zero) risk of non-deterministic build results when users rebuild the package - Not much of an issue when building the package inside of a build system as part of a distro, except that it might tie this package to the specific environment it is being built on - I am not sure what to do about it. Hardcoding? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review