https://bugzilla.redhat.com/show_bug.cgi?id=834582 Gerard Ryan <gerard@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Gerard Ryan <gerard@xxxxxxx> --- (In reply to comment #3) > It really *IS* named %{name}.spec. You can extract the SRPM and you'll see > it is named "java-deptools.spec". Only the name in the URL used only for > this review is different. > Ah yes, my mistake (or the mistake of fedora-review tool, rather). > > Guidelines says that "original files" should have their timestamps > preserved, but files in "target/site/apidocs" are NOT original files -- they > are being generated during build time. Their times are set during the build > time and preserving them makes no sense. The only original file, pom.xml, > does have its timestamp preserved. Yes, you are right! Everything else looks good, thanks for such a useful tool! ================ *** APPROVED *** ================ -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review