[Bug 834516] Review Request: perl-Devel-StringInfo - Gather information about strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=834516

--- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Source file is original. Ok.
Summary verified from lib/Devel/StringInfo.pm.

FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm).

Description verified from lib/Devel/StringInfo.pm. Ok.
No XS code, noarch BuildArch is Ok.
URL and Source0 are usable. Ok.
Build-requires are Ok.
All tests pass. Ok.

$ rpmlint  perl-Devel-StringInfo.spec
../SRPMS/perl-Devel-StringInfo-0.04-1.fc18.src.rpm
../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jun 22 15:04
/usr/share/doc/perl-Devel-StringInfo-0.04
-rw-r--r--    1 root    root                      160 May 14  2009
/usr/share/doc/perl-Devel-StringInfo-0.04/Changes
-rw-r--r--    1 root    root                     3365 Jun 22 15:04
/usr/share/man/man3/Devel::StringInfo.3pm.gz
drwxr-xr-x    2 root    root                        0 Jun 22 15:04
/usr/share/perl5/vendor_perl/Devel
-rw-r--r--    1 root    root                     7976 May 14  2009
/usr/share/perl5/vendor_perl/Devel/StringInfo.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Encode)
      1 perl(Encode::Guess)
      1 perl(:MODULE_COMPAT_5.14.2)
      1 perl(Moose)
      1 perl(namespace::clean)
      1 perl(Scalar::Util)
      1 perl(Sub::Exporter)
      1 perl(Tie::IxHash)
      1 perl(utf8)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77).
FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91).

$ rpm -q --provides -p
../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Devel::StringInfo) = 0.04
      1 perl-Devel-StringInfo = 0.04-1.fc18
Binary provides are Ok.

Package builds in F18
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4188014). ???

Otherwise package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' prefix issues and provides new spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]