https://bugzilla.redhat.com/show_bug.cgi?id=825854 --- Comment #23 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> --- Thank you for the update. I did a full review on this: ! rpmlint says zita-alsa-pcmi.x86_64: W: spelling-error %description -l en_US clalsadrv -> clausal zita-alsa-pcmi.x86_64: W: spelling-error %description -l en_US initialise -> initialize, initial, inessential zita-alsa-pcmi.x86_64: W: spelling-error %description -l en_US hw -> he, h, w zita-alsa-pcmi.x86_64: W: spelling-error %description -l en_US mmap -> map, m map, mamma zita-alsa-pcmi.src: W: spelling-error %description -l en_US clalsadrv -> clausal zita-alsa-pcmi.src: W: spelling-error %description -l en_US initialise -> initialize, initial, inessential zita-alsa-pcmi.src: W: spelling-error %description -l en_US hw -> he, h, w zita-alsa-pcmi.src: W: spelling-error %description -l en_US mmap -> map, m map, mamma Let us ignore the above. zita-alsa-pcmi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/zita-alsa-pcmi-0.2.0/apps/mtdm.cc zita-alsa-pcmi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/zita-alsa-pcmi-0.2.0/apps/alsa_loopback.cc zita-alsa-pcmi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/zita-alsa-pcmi-0.2.0/apps/alsa_delay.cc zita-alsa-pcmi-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/zita-alsa-pcmi-0.2.0/apps/mtdm.h zita-alsa-pcmi-utils.x86_64: W: no-documentation zita-alsa-pcmi-utils.x86_64: W: no-manual-page-for-binary alsa_loopback zita-alsa-pcmi-utils.x86_64: W: no-manual-page-for-binary alsa_delay zita-alsa-pcmi-devel.x86_64: W: no-documentation It would be good to contact upstream to do something for the above. ! For both of the patches you can do something like -CXXFLAGS += -O2 -Wall -MMD -MP +CXXFLAGS += -O2 -Wall -MMD -MP -I../libs $(OPTFLAGS) so that you don't remove the upstream optimization flags when no OPTFLAGS was specified. Your OPTFLAGS will override whatever there was initially. Please submit your patches upstream and leave a comment in your specfile about the patch status. A link to upstream bugtracker or mailing list archive would be nice. * The utils subpackge should have license GPLv2+ and GPLv3+. Please take a look at the source code under apps/*. Also please indicate this in the specfile as a comment (which files are GPLv2+, which are GPLv3+ etc.). * The devel package MUST require alsa-lib-devel. See libs/zita-alsa-pcmi.h * Please replace %{?smp_mflags} with %{?_smp_mflags} -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review