[Bug 658754] Review Request: CUBRID - a very fast and reliable open source SQL database server.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=658754

Cristian Ciupitu <cristian.ciupitu@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cristian.ciupitu@xxxxxxxxx
              Flags|                            |needinfo?(esen.sagynov@nhn.
                   |                            |com)

--- Comment #7 from Cristian Ciupitu <cristian.ciupitu@xxxxxxxxx> ---
The packaging guidelines[1] say that gcc and gcc-c++ are part of the minimum
build environment which means that you should remove them from the spec,
including glibc-devel (a dependency of gcc) and libstdc++-devel (a dependency
of gcc-c++).

You shouldn't delete the cubrid user when the package is uninstalled. The
guidelines say: "we never remove users or groups created by packages"[2].

Regarding the non-standard-uid/gid warning: why are so many files belonging to
the cubrid user/group? Assign to cubrid only what's needed. There's no need to
assign program files (executables, libraries) to cubrid, only data and
settings.

Try moving {_bindir}/cubrid to a separate Source or in the main archive,
instead of including it in the spec file.

Try replacing chkconfig and service commands from %post and %preun with the
systemd equivalents.

I'm not sure about this, but you should remove the post install message in
keeping with the Unix philosophy that "no news is good news".

P.S. my koji scratch build in case someone else wants to have a look at it -
http://koji.fedoraproject.org/koji/taskinfo?taskID=4182512

[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

[2] http://fedoraproject.org/wiki/Packaging:UsersAndGroups

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]