https://bugzilla.redhat.com/show_bug.cgi?id=822472 --- Comment #4 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> --- (In reply to comment #3) > Some RHEL 5-related issues as in previous packages, I'd say the only one you > should definitely fix before uploading is removing the unnecessary %defattr, > but there's no need to re-review. APPROVED > Forgot to mention the other minor issue below (use %{buildroot} or $RPM_BUILD_ROOT consistently) - package is still approved. > [!]: MUST Package consistently uses macros (instead of hard-coded directory > names). > Note: Using both %{buildroot} and $RPM_BUILD_ROOT > See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros > -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review