https://bugzilla.redhat.com/show_bug.cgi?id=785494 Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx, | |shawn.iwinski@xxxxxxxxx --- Comment #1 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- I am not an official package reviewer, but here are some comments I have for this package: *** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements *** Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** Your Provides statement should be Provides: php-pear(pear.horde.org/%{pear_name}) = %{version} instead of Provides: php-pear(%{pear_name}) = %{version} *** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual provides "php-date", "php-pcre" and "php-zlib". *** All locale %files should be tagged with "%lang(xx)". rpmlint warnings: php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ar/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/bg/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/bs/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ca/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/cs/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/da/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/de/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/el/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/en/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/es/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/et/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/eu/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fa/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fi/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fr/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/gl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/he/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/hr/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/hu/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/id/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/is/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/it/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ja/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/km/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ko/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/lt/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/lv/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/mk/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nb/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nn/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pt/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pt_BR/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ro/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ru/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sk/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sv/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/tr/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/uk/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/zh_CN/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/zh_TW/LC_MESSAGES/Horde_Compress.mo *** Do you plan on building for EPEL 5? - If not, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag). - If you do, there are several staements that need to be added. *** Up to you, but package.xml lists the optional package php-pear(pear.horde.org/Horde_Stream_Filter) if you choose to require (if you do choose to require this package, please update this ticket's "Depends On") -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review