[Bug 785495] Review Request: php-horde-Horde-Data - Horde Data API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=785495

Shawn Iwinski <shawn.iwinski@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxxxxxxxxx,
                   |                            |shawn.iwinski@xxxxxxxxx

--- Comment #1 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
I am not an official package reviewer, but here are some comments I have for
this package:



*** It would help readability to group your Build* and Requires* statements
together instead of mixing them with each other and your Provides and Conflicts
statements



*** Your BuildRequires should be
BuildRequires:  php-pear(PEAR) >= 1.7.0
instead of
BuildRequires:  php-pear >= 1:1.4.9-1.2
(this would match what you have in bug 785606 and satisfy this package's
package.xml dependency)



*** Your Provides statement should be
Provides:    php-pear(pear.horde.org/%{pear_name}) = %{version}
instead of
Provides:    php-pear(%{pear_name}) = %{version}



*** phpci results: For completeness (and to prevent any future packaging issues
due to PHP package changes), you may wish to require the virtual provides
"php-date" and "php-pcre".



*** All locale %files should be tagged with "%lang(xx)".  Some rpmlint
warnings:
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/ar/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/bg/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/bs/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/ca/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/cs/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/da/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/de/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/el/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/en/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/es/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/et/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/eu/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/fa/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/fi/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/fr/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/gl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/he/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/hr/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/hu/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/id/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/is/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/it/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/ja/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/km/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/ko/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/lt/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/lv/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/mk/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/nb/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/nl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/nn/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/pl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/pt/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/pt_BR/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/ro/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/ru/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/sk/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/sl/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/sv/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/tr/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/uk/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/zh_CN/LC_MESSAGES/Horde_Data.mo
php-horde-Horde-Data.noarch: W: file-not-in-%lang
/usr/share/pear/data/Horde_Data/locale/zh_TW/LC_MESSAGES/Horde_Data.mo



*** Do you plan on building for EPEL 5?
- If not, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag).
- If you do, there are several staements that need to be added.



*** You may wish to contact upstream to fix their package.xml as Horde_Util is
listed as both required and optional

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]