[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=826563

Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail@xxxxxxxxxxxxxxxxxx

--- Comment #4 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
Just some quick comments: 

- You are mixing macro and variable style
- The numbering in your changelog needs a reset when updating the package
- defattr is no longer needed
- hicolor-icon-theme is a requirement
- Working with wildcards in your %files section will make your life easier in
the future when updating the package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]