https://bugzilla.redhat.com/show_bug.cgi?id=717748 --- Comment #14 from Scott Tsai <scottt.tw@xxxxxxxxx> --- (In reply to comment #13) > > 1. License should be "LGPLv2 and GPLv2" > OK > Do you think it would be more appropriate to put it into a separate package? No, I think the existing arrangement is fine. There are many packages with "LGPLxx and GPLxx" in the license field in Fedora. I just always want to make a good faith effort on documenting the license during package review. > > 4. ExclusiveArch and arm > I'll review the list of supported arch and replace it by an explicit > ExcludeArch if necessary. ok. For your convenience, I've uploaded the .spec with my recommended changes here: http://scottt.tw/fedora/lttng-ust.spec After you update your .spec I'll do a quick diff against that and I think we're good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review