https://bugzilla.redhat.com/show_bug.cgi?id=832635 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- just some quick comments: - %defattr is no longer needed, it's the default - 'BuildRoot' is obsolete for recent Fedora versions. - The .desktop file is not handled correct, https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - http://evoluspencil.googlecode.com/files/pencil-2.0.tar.gz gives an 404 error -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review