[Bug 833411] Review Request: realmd - Kerberos realm enrollment service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=833411

--- Comment #5 from Yanko Kaneti <yaneti@xxxxxxxxxxx> ---
(In reply to comment #4)
> (In reply to comment #1)
> > try rpmlint on the result:  (here is an excerpt)
> 
> Oddly enough, my rpmlint doesn't show those warnings:
> 
> [stef@stef-rawhide rpm]$ rpmlint SPECS/realmd.spec 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Probably because you've only tried it on the spec.
Try it on the spec, srpm, built rpms and even the debuginfo.
Here are additional errors it finds here. rpmlint-1.4-6.fc17.noarch

realmd.x86_64: E: incorrect-fsf-address /usr/share/doc/realmd-0.3/COPYING
realmd-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/realmd-0.3/service/realm-command.c
realmd-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/realmd-0.3/service/realm-command.h

> > Also from 
> > BuildRequires:  automake libtool intltool pkgconfig
> > you only need intltool   Unless you auto(make/conf/reconf).

> We do run pkg-config, or is that build requirement automatically provided?

Its currently required by rpm-build which is in the minimal build root
http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
I think it should be in the Expections list but, but its fine if it stays.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]