[Bug 833411] Review Request: realmd - Kerberos realm enrollment service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=833411

Yanko Kaneti <yaneti@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yaneti@xxxxxxxxxxx

--- Comment #1 from Yanko Kaneti <yaneti@xxxxxxxxxxx> ---
try rpmlint on the result:  (here is an excerpt)
realmd.x86_64: E: explicit-lib-dependency PackageKit-glib
realmd.x86_64: E: explicit-lib-dependency glib2
realmd.x86_64: E: explicit-lib-dependency krb5-libs
realmd.x86_64: W: incoherent-version-in-changelog 0.3 ['0.3-1.fc18', '0.3-1']

You don't need to include explicit deps on shared libraries which will be
picked up by the rpm dep generator.

Also from 
BuildRequires:  automake libtool intltool pkgconfig
you only need intltool   Unless you auto(make/conf/reconf).

Explicit BuildRoot: tag is not needed since a release or two ago.
Same for %defattr(-,root,root,-)
Same for the explicit rm -f %{buildroot} in the start of %clean or %install
Group:   is obosolete

You should own %{_libdir}/realmd, as in
%dir %{_libdir}/realmd
and
%dir %{_libdir}/realmd/provider.d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]