https://bugzilla.redhat.com/show_bug.cgi?id=830277 --- Comment #8 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- The release tag is not good. The release number is missing but is mandatory: it defines the number of times the package has been modified using the same version of the packaged software. According to the guidelines (see links above), it should look like this: Release: 1.f%{?dist} Take also advantage of the macros, especially in the Source tag: Release: 1.%{postver}%{?dist} [...] Source: http://hules.free.fr/wmcoincoin/download/%{name}-%{version}%{postver}.tar.gz Thanks to macros, you only modify once release and version numbers when you update your package. Please use breakline to separate each section of your .spec file, it'll make your spec file easier to read: <linebreak> %prep %setup -q -n %{name}-%{version}%{postver} [...] <linebreak> %build %configure [...] The scriplets (%post/%postun/%posttrans) are completely useless here: - no icon is installed in /usr/share/icons/ by your package; - there's no MimeType key in your desktop file. Please remove them. http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Please remove the Encoding key in your .desktop file, it's deprecated: http://standards.freedesktop.org/desktop-entry-spec/0.9.5/apd.html > - Don't forget to add a final dot in English and French descriptions. > Sentences always end with a dot. Only descriptions, not summaries. rpmlint complains about summaries ending with a dot. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review