https://bugzilla.redhat.com/show_bug.cgi?id=822730 --- Comment #10 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- Currently I am on holidays with limited internet access, so my response time is a bit longer :) I will be back in office 2012-06-25. Other things that I have spotted so far: * I guess the license is GPLv2+, according to the text in /etc/apm/event.d/laptop-mode and also taking into account: https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F but probably the best would be to ask the author. * Do not use macros for system commands, eg. %{__rm}, use rm instead: http://fedoraproject.org/wiki/Packaging:Guidelines#Macros * The %clean section or explicitly cleaning of the buildroot by 'rm -rf %{buildroot}' is not needed unless you are also packaging for EPEL-5 or lower: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean * Escape macros in changelog by %, e.g. %%{__install}. * Make man pages non-executable and compress them. * Executables shouldn't be marked as config files. * Also check all (S)RPMs with rpmlint, it seems there are some more problems: rpmlint laptop-mode-tools-1.61-3.fc18.src.rpm laptop-mode-tools.src: W: spelling-error %description -l en_US userland -> user land, user-land, slanderous laptop-mode-tools.src: W: invalid-license GPL laptop-mode-tools.src:21: W: setup-not-quiet laptop-mode-tools.src:25: W: rpm-buildroot-usage %build %{__rm} -rf %{buildroot} laptop-mode-tools.src:27: W: rpm-buildroot-usage %build DESTDIR=%{buildroot} INIT_D="" MAN_D=%{_mandir} INSTALL=install ./install.sh laptop-mode-tools.src:30: W: rpm-buildroot-usage %build rm %{buildroot}/etc/init.d/laptop-mode laptop-mode-tools.src:32: W: rpm-buildroot-usage %build %{__mkdir_p} -m0755 %{buildroot}%{_initrddir} laptop-mode-tools.src:33: W: rpm-buildroot-usage %build %{__install} -Dp -m755 etc/init.d/laptop-mode %{buildroot}%{_initrddir} laptop-mode-tools.src:70: E: hardcoded-library-path in /usr/lib/pm-utils/sleep.d/* laptop-mode-tools.src:75: E: hardcoded-library-path in /usr/lib/pm-utils/sleep.d laptop-mode-tools.src:133: W: macro-in-%changelog %{__install} laptop-mode-tools.src: W: no-%install-section 1 packages and 0 specfiles checked; 2 errors, 10 warnings. rpmlint laptop-mode-tools-1.61-3.fc18.noarch.rpm laptop-mode-tools.noarch: W: manpage-not-compressed gz /usr/share/man/man8/laptop-mode.conf.8 laptop-mode-tools.noarch: W: manpage-not-compressed gz /usr/share/man/man8/lm-syslog-setup.8 laptop-mode-tools.noarch: W: manpage-not-compressed gz /usr/share/man/man8/lm-profiler.8 laptop-mode-tools.noarch: W: manpage-not-compressed gz /usr/share/man/man8/laptop_mode.8 laptop-mode-tools.noarch: W: manpage-not-compressed gz /usr/share/man/man8/lm-profiler.conf.8 laptop-mode-tools.noarch: W: spelling-error %description -l en_US userland -> user land, user-land, slanderous laptop-mode-tools.noarch: W: invalid-license GPL laptop-mode-tools.noarch: W: only-non-binary-in-usr-lib laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/acpi/events/lm_ac_adapter laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/acpi/actions/lm_ac_adapter.sh laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/acpi/events/lm_lid laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/acpi/actions/lm_lid.sh laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/rc.d/init.d/laptop-mode laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/acpi/events/lm_battery laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/acpi/actions/lm_battery.sh laptop-mode-tools.noarch: W: conffile-without-noreplace-flag /etc/udev/rules.d/99-laptop-mode.rules laptop-mode-tools.noarch: E: incorrect-fsf-address /etc/apm/event.d/laptop-mode laptop-mode-tools.noarch: E: non-standard-executable-perm /usr/share/man/man8/laptop-mode.conf.8 0744L laptop-mode-tools.noarch: W: spurious-executable-perm /usr/share/man/man8/laptop-mode.conf.8 laptop-mode-tools.noarch: E: executable-marked-as-config-file /etc/acpi/actions/lm_ac_adapter.sh laptop-mode-tools.noarch: E: non-standard-executable-perm /usr/share/man/man8/lm-syslog-setup.8 0744L laptop-mode-tools.noarch: W: spurious-executable-perm /usr/share/man/man8/lm-syslog-setup.8 laptop-mode-tools.noarch: E: executable-marked-as-config-file /etc/acpi/actions/lm_lid.sh laptop-mode-tools.noarch: E: non-standard-executable-perm /usr/share/man/man8/lm-profiler.8 0744L laptop-mode-tools.noarch: W: spurious-executable-perm /usr/share/man/man8/lm-profiler.8 laptop-mode-tools.noarch: E: non-standard-executable-perm /usr/share/man/man8/laptop_mode.8 0744L laptop-mode-tools.noarch: W: spurious-executable-perm /usr/share/man/man8/laptop_mode.8 laptop-mode-tools.noarch: E: non-standard-executable-perm /usr/share/man/man8/lm-profiler.conf.8 0744L laptop-mode-tools.noarch: W: spurious-executable-perm /usr/share/man/man8/lm-profiler.conf.8 laptop-mode-tools.noarch: E: incorrect-fsf-address /usr/share/doc/laptop-mode-tools-1.61/COPYING laptop-mode-tools.noarch: E: executable-marked-as-config-file /etc/rc.d/init.d/laptop-mode laptop-mode-tools.noarch: E: standard-dir-owned-by-package /usr/sbin laptop-mode-tools.noarch: E: executable-marked-as-config-file /etc/acpi/actions/lm_battery.sh laptop-mode-tools.noarch: E: subsys-not-used /etc/rc.d/init.d/laptop-mode laptop-mode-tools.noarch: W: incoherent-init-script-name laptop-mode ('laptop-mode-tools', 'laptop-mode-toolsd') 1 packages and 0 specfiles checked; 13 errors, 22 warnings. I think it is not good idea to rename the package to something like fedora-*, because AFAIK there is no conflict to resolve. We should stay as close to upstream as possible (all the changes that would make sense we should get upstream). I will do the transition to systemd, no problem, stay tuned :) Finally my personal point of view: AFAIK the laptop mode kernel feature is fading out as the SSDs are more and more common (I know that the tool can do much more, but this is presented as the core functionality in the docs). Also the power saving mechanism that depends on AC/battery mode is not sophisticated (e.g. some users may need full performance on battery to complete their task more quickly and then go to idle and save more power), so the shipped defaults may not be optimal for everybody. <advertisement> In Fedora we are working on Tuned project and we try to resolve this via profiles (also if required, the profiles can be switched automatically by /etc/pm/power.d script but we don't do it by default). If you are interested, contributions are welcome :) http://fedorahosted.org/tuned/ </advertisement> -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review