[Bug 825415] Review Request: opensmtpd - Free implementation of the server-side SMTP protocol as defined by RFC 5321

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825415

--- Comment #16 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> ---
https://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir:

Packagers are highly encouraged to store libexecdir files in a package-specific
subdirectory of %{_libexecdir}, such as %{_libexecdir}/%{name}. 


your files section contains:
%{_libexecdir}/mail.local


opensmtpd uses config in /etc/mail, which is owned by sendmail.

Regarding /etc/mail, please take a look at
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

[root@sofja ~]# rpmquery -f /usr/bin/mailq
sendmail-8.14.5-12.fc17.i686
[root@sofja ~]# rpmquery -f /usr/bin/newaliases
sendmail-8.14.5-12.fc17.i686
[mrunge@sofja opensmtpd]$ repoquery -f /usr/sbin/makemap
sendmail-0:8.14.5-12.fc17.i686


Looks like you're using filenames from sendmail which produces a conflict.
https://fedoraproject.org/wiki/Packaging:Conflicts#Binary_Name_Conflicts


- you didn't package the latest version
- you definitely need to include the license file, I'd also include the readme.
(as %doc)

- finally: how are you going to handle openbsd-compat? It includes several
files not originating from opensmtpd. 

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

List of files and where they come from

base64.{c,h}            portable openssh
basename.c              portable openssh
bsd-arc4random.c        portable openssh
bsd-closefrom.c         portable openssh
bsd-getpeereid.c        portable openssh
bsd-waitpid.{c,h}       portable openssh
daemon.c                portable openssh
defines.h               portable openssh
dirname.c               portable openssh
entropy.{c,h}           portable openssh
fgetln.c                part of /usr/src/usr.bin/make/util.c
fmt_scaled.c            portable openssh
fparseln.c              part of /usr/src/libutil/fparseln.c
getopt.c                portable openssh
imsg-buffer.c           part of /usr/src/libutil/imsg-buffer.c
imsg.{c,h}              part of /usr/src/libutil/imsg.c
includes.h              portable openssh
log.h
mktemp.c                portable openssh
openbsd-compat.h        
setproctitle.c          portable openssh

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]