https://bugzilla.redhat.com/show_bug.cgi?id=825854 --- Comment #16 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> --- Sorry, I accidentally downloaded the SRPM from the original post. Now, as a starter, I want to point a few things: * Changelog format does not fit the requirements: http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs ! -I../libs is not required in libs/Makefile. It is only required in apps.Makefile. * In the buildlog I see lines such as g++ -L/usr//usr/lib -o alsa_loopback ... Probably because of the line LDFLAGS += -L$(PREFIX)/$(LIBDIR) It would be nice to fix this. Well, since this is your first package, let us do the things the proper way. Instead of hacking in the Makefiles with sed, it would be good to make patches and send them upstream. This will require a different approach at a few places. For instance, since we want to be able to override the CXXFLAGS, we might want to change CXXFLAGS += -O2 -Wall ... with something like CXXFLAGS += -O2 -Wall ... -I../libs $(OPTFLAGS) Then specify OPTFLAGS=%{optflags} in your make line. Of course there are other methods, but this one is simple and upstreamable. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review