Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: icon-slicer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225895 roozbeh@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |davidz@xxxxxxxxxx Flag| |fedora-review- ------- Additional Comments From roozbeh@xxxxxxxxxxxxx 2007-02-06 05:38 EST ------- Random first notes: * change BuildPrereq to BuildRequires * change Release to integer value, perhaps also using %{?dist} * change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * License field says MIT, but there is a copy of GPL in the tarball named COPYING! * ship at least ChangeLog and AUTHORS in %doc * use make DESTDIR=$RPM_BUILD_ROOT install instead of %makeinstall * change %defattr(-,root,root) to %defattr(-,root,root,-) * use make %{?_smp_mflags} instead of make * provide URL field * provide complete URL of source tarball in the Source field -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review