https://bugzilla.redhat.com/show_bug.cgi?id=808258 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@xxxxxxxxx --- Comment #7 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- I noticed that another review request was opened by someone else for this package. I've encouraged him to review this one instead. I took a quick look since packages with conflciting names can often cause problems. It looks like there's no file-level conflicts between this package and python-pbs as python-pbs uses a directory-based module and this package uses a file-based module but I'd very strongly recommend against shipping the pbs.py{,c,o} files. If I was reviewing, I'd block the package on it. The problem is that a system having both python-pbs and python-sh installed will not be able to import one or the other of the modules. Simply moving the %{python_sitelib}/pbs.py{,c,o} files to %{python_sitelib}/sh.py{,c,o} instead of creating a symlink should resolve that. Note that the egg-info for python-pbs is pbs_python and the egg-info for this package is python_pbs. This is not a direct conflict but it is confusing... I'd recommend (but perhaps not block) this package on removing the python_pbs egg-info for this package. Also regarding egg-info, you should probably ship a python_sh egg-info. You can use a symlink or a mv depending on whether you're going to remove the python_pbs egginfo. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review